| Summary: | RSS feed for new comments is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, magnus, nengard, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 8708 - RSS feed for new comments is broken
[SIGNED-OFF] Bug 8708 - RSS feed for new comments is broken Bug 8708 [Revised] RSS feed for new comments is broken [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken |
||
|
Description
Owen Leonard
2012-08-31 13:02:02 UTC
Created attachment 11911 [details] [review] Bug 8708 - RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Hi Owen, I have not tested this patch. But if it just removes boundary characters, I think a comment is welcomed. Indeed if a stubborn of alignment and indentation (like me !) read that in the future, he would certainly re-add them :) Sorry Jonathan, but I'm confused. Are you asking for more information? Maybe a TT-comment that says "Make sure there are no spaces/newlines here, it will ruin the XML processing"? And use [%- and -%] to remove whitespace introduced by the comment? (In reply to comment #4) > Maybe a TT-comment that says "Make sure there are no spaces/newlines here, > it will ruin the XML processing"? And use [%- and -%] to remove whitespace > introduced by the comment? It is exactly what I meant, thanks Magnus :) Created attachment 11918 [details] [review] [SIGNED-OFF] Bug 8708 - RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> The recent comments feed works as expected now. Signing off. Created attachment 11984 [details] [review] Bug 8708 [Revised] RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Revision: Template now includes comment pointing out that the <xml> declaration must not have any white space before it. Created attachment 11991 [details] [review] [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Revision: Template now includes comment pointing out that the <xml> declaration must not have any white space before it. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Thank you Owen. Marked as Passed QA. Patch pushed to master (Not sure this patch applies or is relevant for 3.8) Pushed to 3.8.x will be in 3.8.5 |