| Summary: | Warning message triggered by clicking keyword to marc mapping. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | System Administration | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, mtj, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Warning message triggered by clicking "Keywords to MARC mapping"
Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping |
||
|
Description
Mark Tompsett
2012-09-03 02:58:15 UTC
Created attachment 11941 [details] [review] Warning message triggered by clicking "Keywords to MARC mapping" To reproduce the warning: 1) Log in to staff client 2) Click 'Koha administration' 3) Click 'Keywords to MARC mapping' 4) Check koha-error_log [Mon Sep 03 09:51:45 2012] [error] [client 192.168.100.2] [Mon Sep 3 09:51:45 2012] fieldmapping.pl: Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/admin/fieldmapping.pl line 65., referer: https://.../cgi-bin/koha/admin/admin-home.pl Apply patch. No warning triggered. Tested in 3.6.3, but same patch should apply to 3.6.x, 3.8.x, and master. The attached patch is against master. Created attachment 11954 [details] [review] Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping In the Koha Administration screen, clicking Keywords to MARC mapping triggered an uninitialized $op warning in the koha error logs. Added a "|| q{}" to ensure it is set. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 493b9c2 Bug 8713 - Warning message triggered by clicking Keywords to MARC admin/fieldmapping.pl * admin/fieldmapping.pl OK Patch pushed to master Tiny patch to silence some warns, pushed to 3.8.x will be in 3.8.5 |