| Summary: | browse overlaying powered by | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, kyle, paul.poulain, veron |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
powered by floats on top
Bug 8730 - browse overlaying powered by Bug 8730 - browse overlaying powered by |
||
Created attachment 12023 [details] [review] Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. The result of the patch is:
a.koha_url {
display: none;
background-color:#F3F3F3;
padding-bottom:10px;
z-index: 100;
}
koha_url is related to the "Powered by..." Link (not to the browse results):
<a class="koha_url" rel="nofollow" href="http://koha-community.org">Koha</a>
...and a positive z-index will bring it on the top of the other contents, not behind, see:
https://developer.mozilla.org/en-US/docs/CSS/Understanding_z-index/Adding_z-index
Or did I miss something? :-)
Marc
The result of applying the patch should be this (starting at line 2219):
a.koha_url {
text-decoration:none;
}
/* pagination */
.pagination {
position: absolute;
top:32px;
left: -1px;
width: 100%;
height:auto;
border: 1px solid #D0D0D0;
display: none;
background-color:#F3F3F3;
padding-bottom:10px;
+ z-index: 100;
}
Are you sure you're applying the patch on master?
Created attachment 12044 [details] [review] Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Owen, Sorry for the confusion. Maybe it was a cache problem. Just tested again and it worked fine. While I was testing Kyle signed off :-) Marc works as expected, simple patch, nothing to say. Marked as Passed QA Patch pushed to master No string changes, pushed to 3.8.x, will be in 3.8.5 |
Created attachment 11989 [details] powered by floats on top When you use the browse results option on the detail page in conjunction with the powered by Koha message it overlays funny - the powered by comes on top of the browse but should probably fall behind.