Summary: | Incorrect icon at login in staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Templates | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, kyle, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Sets missing environment variable so correct icon is displayed.
Bug 8737 - Incorrect icon at login in staff client |
Description
Mark Tompsett
2012-09-07 05:32:46 UTC
Created attachment 12032 [details] [review] Sets missing environment variable so correct icon is displayed. I initially did a tarball install of 3.6.3 and hacked the template files to get it right. This patch against master should be the correct solution to the problem. This problem exists in 3.6.X and I believe 3.8.X as well. I followed the simple steps given in my previous comments to confirm after applying the patch. Created attachment 12046 [details] [review] Bug 8737 - Incorrect icon at login in staff client Added the following missing code to ensure the correct icon is used when logged out: IntranetFavicon => C4::Context->preference('IntranetFavicon') This was added into an existing $template->param() call. Not to be confused with the koha logo on the login page, the icon is a 16x16 pixel graphic in the browser tab. The default is found at .../intranet-tmpl/prog/en/includes/favicon.ico. If the "IntranetFavicon" system preference is set, it should be used by the staff client regardless of login state. It was not being used in the "AUTH rejected" section of Auth.pm, but the OpacFavicon variable was being set. This explains why the "OpacFavicon" system preference works for the OPAC client, but not the staff client upon logout. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment: trivial patch More a minor bugfix than an ENH. Patch pushed to master Pushed to 3.8.x will be in 3.8.12 (was released with 3.10.0) |