Summary: | Partial Fine Payments Saving Amount Paid Incorrectly | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Patrons | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt, kyle.m.hall, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly
[SIGNED-OFF] Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly |
Description
Kyle M Hall (khall)
2012-09-07 15:43:41 UTC
Created attachment 12057 [details] [review] Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly Can you please add a test plan for this? * Create two fines * Make a partial payment one fine 1, make a full payment on the other * Look at the fines in koha, one payment will be green, the other red. This reflects the positive or negative signed-ness of the payment. * Apply the patch and repeat. Created attachment 12256 [details] [review] [SIGNED-OFF] Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed using test plan that the display is corrected. QA comment: * the makepayement sub also reverse the amount paid: # create new line my $payment = 0 - $amount; my $ins = $dbh->prepare( "INSERT INTO accountlines (borrowernumber, accountno, date, amount, itemnumber, description, accounttype, amountoutstanding, manager_id) VALUES ( ?, ?, now(), ?, ?, 'Payment,thanks', 'Pay', 0, ?)" ); so it's consistent * tiny patch (and it's a bugfix !) * koha-qa.pl OK (there were 2 perlcritic violations, that were not related to this patch, and that i've fixed) passed QA Pushed to 3.8.x, will be in 3.8.6 |