Summary: | Chronological terms authorities not correctly indexed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | MARC Authority data support | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, chris, jcamins, magnus, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8750 - Chronological terms authorities not correctly indexed
Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix) Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix) |
Description
Tomás Cohen Arazi (tcohen)
2012-09-10 18:23:39 UTC
Created attachment 12118 [details] [review] Bug 8750 - Chronological terms authorities not correctly indexed There was no entry in authority's record.abs for indexing chronological terms. They ccouldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+ Sponsored-by: Universidad Nacional de Córdoba Note: this is not an issue if using DOM for authorities. To test, 1- Add a Chronological term in your authorities. 2- Reindex them or wait for your cron/daemon to do it. 3- Search for your chronologicla term (wont find it). 4- Apply this patch. 5- Restart your zebrasrv. 6- Reindex & search for your chronological term. I attempted to sign off on this patch. I first tried searching for authority records on master and was unable to retrieve any authority records. (I can search for authority records on 3.8.4) More testing required on this patch. (In reply to comment #3) > I attempted to sign off on this patch. I first tried searching for > authority records on master and was unable to retrieve any authority > records. (I can search for authority records on 3.8.4) Are you sure the zebra daemon started properly? I can't test this at the moment, but it is worth noting that there are several implied steps for testing this patch: 1) apply patch 2) rerun Makefile.PL to choose GRS-1 indexing for authorities 3) update Zebra configuration files by running make && make install 4) reindex zebra using rebuild_zebra.pl -a -r 5) search for chronological term Valid point! I'm testing on my local install and assumed it was running, I will double check and retest. Thanks!
> Are you sure the zebra daemon started properly?
Created attachment 13069 [details] [review] Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix) Patch re-done so it applies, had that double-utf8 problem There was no entry in authority's record.abs for indexing chronological terms. They ccouldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+ Sponsored-by: Universidad Nacional de Córdoba This bug is important for people still using GRS-1 as binding Chronological Terms authority records to biblios is impossible right now. Created attachment 13149 [details] [review] Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix) Patch re-done so it applies, had that double-utf8 problem There was no entry in authority's record.abs for indexing chronological terms. They couldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: * small patch, MARC21 only * shouldn't we have the same patch for NORMARC ? (adding magnus) * shouldn't we also address DOM indexing ? (biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl) not updating QA status until i've an answer to those questions (In reply to comment #10) > QA comment: > * small patch, MARC21 only > * shouldn't we have the same patch for NORMARC ? (adding magnus) > * shouldn't we also address DOM indexing ? (biblio-koha-indexdefs.xml and > biblio-zebra-indexdefs.xsl) > > not updating QA status until i've an answer to those questions NORMARC does not yet have an authority configuration, and MARC21 DOM files already include this. (In reply to comment #10) > QA comment: > * small patch, MARC21 only > * shouldn't we have the same patch for NORMARC ? (adding magnus) > * shouldn't we also address DOM indexing ? (biblio-koha-indexdefs.xml and > biblio-zebra-indexdefs.xsl) > > not updating QA status until i've an answer to those questions DOM indexing already has those indexes defined. I know nothing about NORMARC, sorry. answers to my question OK, passed QA This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |