Summary: | Code seems useless in circ/returns.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jcamins, kyle.m.hall, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8758: Remove useless code in circ/returns.pl
[SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl |
Description
Jonathan Druart
2012-09-11 13:05:53 UTC
Created attachment 12131 [details] [review] Bug 8758: Remove useless code in circ/returns.pl Could someone confirm this code is unused ? Created attachment 12255 [details] [review] [SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before applying the patch I removed the [% IF %] from around the markup which is removed by this patch. A table of title and patron information appeared which I don't remember ever seeing before. This tells me it's really unused. After applying the patch I performed some check-ins on both checked out items and items which were on hold. All operations completed normally. QA comment: * patch with a very big side effect, if we missed a case where this information is displayed. That's why I won't push it for 3.10, it fit the rule of "Feature Freeze" * koha-qa.pl OK * remove code only passed QA. Will be pushed after 3.10 release (and not pushed by me ;-) ) This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.1 |