| Summary: | Phone number Field tags are reversed in patron record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jesse Maseto <jesse> |
| Component: | Patrons | Assignee: | Jesse Maseto <jesse> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jsasse, kyle.m.hall, m.de.rooy |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Screen Shoot
Screen Shoot 2 Patron data in the OPAC Patron data in the staff client Patron data in the database schema Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. [SIGNED-OFF] Bug 8760 - Phone number Field tags are reversed in patron record Bug 8760 - Phone number Field tags are reversed in patron record |
||
Created attachment 12140 [details]
Screen Shoot 2
Created attachment 24722 [details]
Patron data in the OPAC
Created attachment 24723 [details]
Patron data in the staff client
Created attachment 24724 [details]
Patron data in the database schema
I've attached some additional screenshots highlighting this issue. These mismatched labels cause confusion when processing patron requests for modifications to their personal details. Also, why do the three values each have a different variable type in the database? Phone is text, mobbile is varchar, and fax is mediumtext. Is there a reason for this? Created attachment 26184 [details] [review] Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. Created attachment 26190 [details] [review] [SIGNED-OFF] Bug 8760 - Phone number Field tags are reversed in patron record Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. http://bugs.koha-community.org/show_bug.cgi?id=8760 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 26215 [details] [review] Bug 8760 - Phone number Field tags are reversed in patron record Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. http://bugs.koha-community.org/show_bug.cgi?id=8760 Signed-off-by: Owen Leonard <oleonard@myacpl.org> I'm not convinced that this is the correct fix. After applying the patch, if you enter the following in the phone fields: primary: "primary" secondary: "secondary' other: "mobile" while the staff-side patron display is consistent, the OPAC display is not: Primary phone: primary Secondary phone: mobile Mobile phone: secondary and the database gets populated like this: MariaDB [koha]> select phone, phonepro, mobile from borrowers where borrowernumber = 12092\G *************************** 1. row *************************** phone: primary phonepro: mobile mobile: secondary Consequently, I think that it's members/moremember.tt that needs to be corrected (and perhaps "Mobile" should be used as the label rather than "Other"?) *** This bug has been marked as a duplicate of bug 12407 *** |
Created attachment 12139 [details] Screen Shoot Phone number Field tags are reversed in patron record.