Summary: | Correct compile time warnings in C4::Circulation | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Architecture, internals, and plumbing | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed Patch
Bug 8761 Dont inadvertantly use slices |
Description
Colin Campbell
2012-09-11 17:49:46 UTC
Created attachment 12144 [details] [review] Proposed Patch Doc is perldiag not perlwarn The warns are the same with 5.14 too. I can confirm the patch makes the error goes away, and circ still works fine. Created attachment 12159 [details] [review] Bug 8761 Dont inadvertantly use slices Assignment to a single element slice is better written as a scalar - This generates a compile time warning as it can lead to odd behaviour see perldiag for details This corrects some cases which were added in a recent commit Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I proposed exactly the same patch in Bug 7621 (which introduces these warnings). So I mark it as Passed QA Patch pushed to master +1 to karma colin ;-) Chris_c = not sure this is needed or applying on 3.8 though Released in 3.10.0 |