Summary: | Fix materialTypeCode/typeOf008 icons for NORMARC XSLT | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Staff interface | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, mirko, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8624 | ||
Bug Blocks: | 8662 | ||
Attachments: |
Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT
Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT |
Description
Magnus Enger
2012-09-19 13:27:35 UTC
Broadening the scope of this bug a bit, to cover more (closely related) problems. Created attachment 12455 [details] [review] Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT This patch fixes some issues with icons related to materialtypes in NORMARC: Remove references to opac-tmpl in the *intranet* NORMARC XSLT files. Add two new icons to koha-tmpl/intranet-tmpl/prog/img/famfamfam/ and koha-tmpl/opac-tmpl/lib/famfamfam/ GR.png - Graphical materials TD.png - Three dimentional objects Copy PR.png from koha-tmpl/intranet-tmpl/prog/img/famfamfam/ to koha-tmpl/opac-tmpl/lib/famfamfam/ Rename the XSLT variable materialTypeCode to typeOf008 for increased consistency between stylesheets. Make sure the XSLT uses icons that are actually available. To test: - No use testing all the different permutations of leader pos. 06 and 019b, I think. - Set marcflavour = NORMARC and turn on default XSLT for OPAC and Intranet, details and results. - Make sure you have a record with something relevant in leader position 6, like g for movies or c for music - Check that the icon turns up in results and details, in the OPAC and Intranet - Toggle DisplayOPACiconsXSLT and check that the results in the OPAC are as expected Created attachment 12678 [details] [review] Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT This patch fixes some issues with icons related to materialtypes in NORMARC: Remove references to opac-tmpl in the *intranet* NORMARC XSLT files. Add two new icons to koha-tmpl/intranet-tmpl/prog/img/famfamfam/ and koha-tmpl/opac-tmpl/lib/famfamfam/ GR.png - Graphical materials TD.png - Three dimentional objects Copy PR.png from koha-tmpl/intranet-tmpl/prog/img/famfamfam/ to koha-tmpl/opac-tmpl/lib/famfamfam/ Rename the XSLT variable materialTypeCode to typeOf008 for increased consistency between stylesheets. Make sure the XSLT uses icons that are actually available. To test: - No use testing all the different permutations of leader pos. 06 and 019b, I think. - Set marcflavour = NORMARC and turn on default XSLT for OPAC and Intranet, details and results. - Make sure you have a record with something relevant in leader position 6, like g for movies or c for music - Check that the icon turns up in results and details, in the OPAC and Intranet - Toggle DisplayOPACiconsXSLT and check that the results in the OPAC are as expected Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Before patch: OPAC results: +icon, +norwegian descriptions OPAC detail: -icon, +norwegian descriptions; FV.png not found Staff result: -icon, +norwegian descriptions; Film.png, Sound.png not found Staff detail: -icon, +norwegian descriptions; FV.png not found After patch: OPAC results: +icon, +norwegian descriptions OPAC detail: +icon, +norwegian descriptions; (no errors) Staff result: +icon, +norwegian descriptions; (no errors) Staff detail: +icon, +norwegian descriptions; (no errors) I also tried the new icons. GR.png for 'k' (grafiske materialer) and TD.png for tre-dimensjonale gjenstander ('r') works for me in all areas. Signed off. QA comments * add new icons to famfam directory, they are graphically consistent * the rest is related to NORMARC only, no side-effect risk * passes koha-qa.pl passed QA Patch pushed to master (untested, Magnus, please, double check ;-) ) Pushed to 3.8.x will be in 3.8.6 (In reply to comment #6) > Patch pushed to master > (untested, Magnus, please, double check ;-) ) Works nicely on master, as far as I can tell. |