Summary: | Just add the login branch In orderreveive.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Christophe Croullebois <christophe.croullebois> |
Component: | Acquisitions | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, katrin.fischer, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
proposed patch
Bug 8795: Adding the login branch as default in orderreceive.tt Bug 8795: Adding the login branch as default in orderreceive.tt Patch |
Description
Christophe Croullebois
2012-09-20 07:09:57 UTC
Created attachment 12370 [details] [review] proposed patch Created attachment 13062 [details] [review] Bug 8795: Adding the login branch as default in orderreceive.tt The homebranch and holdingbranch ddl in item block are not default selected. I just put the default choice as the login branch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, orderreceive.pl showed the branches alphabetically. After the patch, it automatically selects the branch I'm logged in to. QA Comment: The PrepareItemrecordDisplay routine seems not very clean, a lot of processing is useless. But it is not the goal of this patch. This patch works as expected. So I mark it as Passed QA. note to test: AcqCreateItem = "receive an order" I would like to get a second QA team sign-off on this patch. Created attachment 13670 [details] [review] Bug 8795: Adding the login branch as default in orderreceive.tt The homebranch and holdingbranch ddl in item block are not default selected. I just put the default choice as the login branch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, orderreceive.pl showed the branches alphabetically. After the patch, it automatically selects the branch I'm logged in to. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Still waiting a second QA team member sign off QA Comment: Works as advertised. Although this patch only adds one line, it was quite hard to verify if it works and where it works. The routine PrepareItemrecordDisplay is used only in: acqui/addorderiso2709.pl C4/Serials.pm serials/serials-edit.pl services/itemrecorddisplay.pl (only called via additem.js) But that is not the full picture: Script orderreceive.pl goes via additem.js to itemrecorddisplay.pl using the routine. Script neworderempty.pl also uses the routine that way. Note that this patch therefore DOES also affect AcqCreateItem=ordering ! Have tested that. The patch makes Acquistion behave like Cataloguing where the routine GetBranchesLoop from Branch.pm already did something similar. Passed QA Created attachment 14210 [details] [review] Patch This patch has been pushed to master. |