Summary: | Quiet errors in the log from Auth.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, mtj, paul.poulain, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8804 - Quiet errors in the log from Auth.pm
[SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm Bug 8804 [Revised] Quiet errors in the log from Auth.pm Bug 8804 [Revised] Quiet errors in the log from Auth.pm |
Description
Owen Leonard
2012-09-21 20:50:10 UTC
Created attachment 12450 [details] [review] Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Created attachment 12458 [details] [review] [SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Signed-off-by: Marc Veron <veron@veron.ch> I could reproduce both errors with the staff client, not with the Opac. After applying the patch no more log entries regarding line 705 and line 384, so I sign off this patch. However I had one more similar log entry (with and without patch) that could be addressed in a follow up: mainpage.pl: Use of uninitialized value $pki_field in string eq at (...)/C4/Auth.pm line 736., referer: http://(...) (In reply to comment #2) > Created attachment 12458 [details] [review] > [SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm > > Signed-off-by: Marc Veron <veron@veron.ch> > trivial patch, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * 445bcca Bug 8804 - Quiet errors in the log from Auth.pm C4/Auth.pm * C4/Auth.pm OK QA comment: OK, i'm a little bit excessive, but that's what QA is made for ;-) Unless i'm mistaking, there is a useless () + if ((($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/) && $opac_limit_override) || ($in->{'query'}->param('limit') && $in->{'query'}->param('limit') =~ /branch:(\w+)/)){ can be written + if (($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/ && $opac_limit_override) || ($in->{'query'}->param('limit') && $in->{'query'}->param('limit') =~ /branch:(\w+)/)){ => if ((A && B && C) || (D && E)) am I right ? If yes, please fix & resubmit Created attachment 13075 [details] [review] Bug 8804 [Revised] Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Revision simplifies logic as per RM suggestion. Created attachment 13183 [details] [review] Bug 8804 [Revised] Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Revision simplifies logic as per RM suggestion. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> As Marc says, there are a few other warnings, but this patch does not claim to fix them. (In reply to comment #6) > Created attachment 13183 [details] [review] > Bug 8804 [Revised] Quiet errors in the log from Auth.pm > > Found three cases where variables were being > referenced which did not (in each case) exist. Adding > checks for those variables' existence. > > Errors appeared when logged in and viewing a detail > page in the OPAC. > > Revision simplifies logic as per RM suggestion. > > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> patch works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit ea72919) * 3460a37 Bug 8804 [Revised] Quiet errors in the log from Auth.pm C4/Auth.pm * C4/Auth.pm OK This patch has been pushed to master. Patch pushed to branch 3.10.x Pushed to 3.8.x will be in 3.8.7 |