Bug 8810

Summary:	Opac: Cart should display branchname instead of branchcode
Product:	Koha	Reporter:	Marc Véron <veron>
Component:	OPAC	Assignee:	Marc Véron <veron>
Status:	CLOSED FIXED	QA Contact:	Mason James <mtj>
Severity:	normal
Priority:	P3	CC:	chris, marc, mtj, paul.poulain, veron
Version:	3.8
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Opac cart displays branchcode Bug 8810 - Opac: Cart should display branchname instead of branchcode [SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode [SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode

Description Marc Véron 2012-09-24 12:48:53 UTC Comment hidden (obsolete)

Created attachment 12469 [details]
Opac cart displays branchcode

In Opac, the cart should display the banchname instead of the branchcode (see screenshot).

Reasons:
- Branchcode is an internal key. Patrons dont necessarily know their meaning.
- The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables.

B.T.W. something similar was made with Bug 3292 (regarding serials)

Patch follows.

Marc

Comment 1 Marc Véron 2012-09-24 13:08:33 UTC Comment hidden (obsolete)

Created attachment 12470 [details] [review]
Bug 8810 - Opac: Cart should display branchname instead of branchcode

In Opac, the cart should display the branchname instead of the branchcode.

Comment 2 Marc Véron 2012-09-24 13:11:27 UTC

Set to "Needs Signoff".

Comment 3 Owen Leonard 2012-09-24 13:23:44 UTC

Created attachment 12471 [details] [review]
[SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode

In Opac, the cart should display the branchname instead of the branchcode.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 4 Owen Leonard 2012-09-24 14:15:18 UTC Comment hidden (obsolete)

Created attachment 12473 [details] [review]
[SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode

In Opac, the cart should display the branchname instead of the branchcode.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 5 Mason James 2012-10-03 00:52:57 UTC

(In reply to comment #4)
> Created attachment 12473 [details] [review]
> [SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of
> branchcode
> 
> In Opac, the cart should display the branchname instead of the branchcode.
> 
> Signed-off-by: Owen Leonard <oleonard@myacpl.org>

passing QA, trival patch

Comment 6 Paul Poulain 2012-10-05 14:26:43 UTC

Patch pushed to master

Comment 7 Chris Cormack 2012-10-06 07:02:56 UTC

Pushed to 3.8.x, will be in 3.8.6