Summary: | Staff Client: Patron search should display branch name instead of branch code in results table | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Staff interface | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt, marc, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table |
Description
Marc Véron
2012-09-24 16:06:40 UTC
Created attachment 12479 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> Created attachment 12580 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> Created attachment 12584 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> (In reply to comment #5) > Created attachment 12584 [details] [review] > Bug 8812 - Staff Client: Patron search should display branch name instead of > branch code in results table > > Patch to display branchname instead of branch code. > > Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * af7db2e Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt members/member.pl * members/member.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt OK QA comment: the branchname information is available, so I accept this patch. But it could have been written using the Koha::Template::Plugin::Branchname template plugin. With caching + new code structure, that will reduce global code size & be as efficient. Would you be OK to provide an alternative patch ? (if no, I'll push this one, no problem with it. But if you can provide a better one, I won't miss that ;-) ) Sorry, I'm afraid I have no time at the moment to find out how to make use of Koha::Template::Plugin::Branchname template plugin. Would appreciate to see it pushed. Marc Patch pushed to master Released in 3.10.0 |