Summary: | YUI CSS files no longer found on Yahoo servers | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, m.de.rooy, mtj, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 8867 | ||
Attachments: |
Bug 8827 - YUI CSS files no longer found on Yahoo servers
[SIGNED_OFF] Patch |
Description
Owen Leonard
2012-09-26 12:46:23 UTC
Created attachment 12525 [details] [review] Bug 8827 - YUI CSS files no longer found on Yahoo servers This patch removes the [% yuipath %] variable from the link to the YUI CSS files in the OPAC and adds a hard-coded path to the local files. To test, set your yuipath system preference to "from Yahoo's servers," clear your browser cache, and view the OPAC. The style and layout should look the same as if your yuipath preference were set to "local." Created attachment 12526 [details] [review] [SIGNED_OFF] Patch Fixes broken display. Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that? (In reply to comment #2) > Created attachment 12526 [details] [review] > [SIGNED_OFF] Patch works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * 47fd399 Bug 8827 - YUI CSS files no longer found on Yahoo servers koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc * koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc OK (In reply to comment #4) > Would it be an idea to add some text next to the pref, mentioning that css > is always local and javascript comes from Yahoo, or something like that? great idea - i've added a new bug to track this http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867 (In reply to comment #6) > (In reply to comment #4) > > Would it be an idea to add some text next to the pref, mentioning that css > > is always local and javascript comes from Yahoo, or something like that? > > great idea - i've added a new bug to track this > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867 ahh, ignore this bug - i just clicked that its CSS *only*, thats local :) Patch pushed to master Patch does not apply to 3.8.x, please resubmit. (In reply to comment #9) > Patch does not apply to 3.8.x, please resubmit. Not applicable to 3.8.x. |