Summary: | can't import authorities | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | critical | ||
Priority: | P1 - high | CC: | chris, jcamins, m.de.rooy, mtj, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8829: Fix authority importing
[SIGNED-OFF] Bug 8829: Fix authority importing |
Description
Nicole C. Engard
2012-09-26 14:53:39 UTC
Created attachment 12539 [details] [review] Bug 8829: Fix authority importing A subroutine was not being imported by C4::ImportBatch (ironic, no?) so this patch makes the call fully-qualified. This patch also cleans up two warnings in C4::Auth that are raised when logged in as the database user. Created attachment 12541 [details] [review] [SIGNED-OFF] Bug 8829: Fix authority importing A subroutine was not being imported by C4::ImportBatch (ironic, no?) so this patch makes the call fully-qualified. This patch also cleans up two warnings in C4::Auth that are raised when logged in as the database user. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> (In reply to comment #2) > Created attachment 12541 [details] [review] > [SIGNED-OFF] Bug 8829: Fix authority importing > > A subroutine was not being imported by C4::ImportBatch (ironic, no?) > so this patch makes the call fully-qualified. This patch also cleans > up two warnings in C4::Auth that are raised when logged in as the > database user. > > Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> patch work well, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 50be765) * 09b39f1 Bug 8829: Fix authority importing C4/Auth.pm C4/ImportBatch.pm * C4/Auth.pm OK * C4/ImportBatch.pm OK I agree with the description and the fact that it's critical. But isn't it caused by the fact that GetAuthorizedHeading isn't exported in C4/AuthoritiesMarc.pm ? Shouldn't we add this sub to expose it (in the .pm) instead of adding a fully qualified name (in ImportBatch) ? (reminder = in Perl, you can't access a sub in a package unless: - it's exported - you fully qualify it [that's why purists says there's not real OO in Perl, because you can't have a really private method in you object] ) (In reply to comment #4) > I agree with the description and the fact that it's critical. > > But isn't it caused by the fact that GetAuthorizedHeading isn't exported in > C4/AuthoritiesMarc.pm ? > Shouldn't we add this sub to expose it (in the .pm) instead of adding a > fully qualified name (in ImportBatch) ? > > (reminder = in Perl, you can't access a sub in a package unless: > - it's exported > - you fully qualify it [that's why purists says there's not real OO in > Perl, because you can't have a really private method in you object] > ) I prefer the fully-qualified name because really GetAuthorizedHeading shouldn't be exported. It should be an object method on Koha::Authority. BuildSummary also should not be exported. However, changing that is a bit more than a bugfix, and I'd prefer not to make master unstable this close to 3.10. OK, thx for the explanation, patch pushed Released in 3.10.0 |