Summary: | Uninitialized variable triggers error log entry in circulation.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Circulation | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jcamins, jonathan.druart, kyle.m.hall, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Added/Replaced with "|| q{}" into variable initialization [3.8.x]
Added/Replaced with "|| q{}" into variable initialization [SIGNED-OFF] Bug 8880 - Uninitialized variables trigger error log entries |
Description
Mark Tompsett
2012-10-05 12:32:15 UTC
Created attachment 12704 [details] [review] Added/Replaced with "|| q{}" into variable initialization [3.8.x] This is the master version. Overlaps with bug 8826, so those changes are included in it. $findborrower, $barcode, $print variables are properly initialized reducing error log entries. Created attachment 12706 [details] [review] Added/Replaced with "|| q{}" into variable initialization This is the 3.8.x version. Overlaps with bug 8826, so those changes are included in it. $findborrower, $barcode, $print variables are properly initialized reducing error log entries. Similar bug exists in 3.6.x, but patch not generated, as neither the master nor 3.8.x versions apply due to the ongoing revisions to the section just above $findborrower's initialization. Created attachment 13358 [details] [review] [SIGNED-OFF] Bug 8880 - Uninitialized variables trigger error log entries Simply by logging in, clicking Circulation, clicking the 'Check out' link, error log entries were generated. This patch ensures $findborrower, $barcode, and $print are all initialized by adding "|| q{}" onto their initializations. This reduces the silent error log entries generated. As this patch would overlap with bug 8826 in the initialization of hashes to prevent other error logs, those changes are in this patch. Applying this patch without having applied the patch for bug 8826. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This was signed off yesterday by Kyle M Hall. QA Comments: Remove warning in log. Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |