| Summary: | Packages can't be built on master, db dependent test | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Cormack <chris> |
| Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | blocker | ||
| Priority: | P1 - high | CC: | jonathan.druart, paul.poulain, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 8846 | ||
| Bug Blocks: | 8924 | ||
| Attachments: |
Bug 8890 - C4::Holdsqueue is db dependent
Bug 8890: C4/HoldsQueue requires DB Bug 8890: don't try to load DB-dependent modules Bug 8890: don't try to load DB-dependent modules Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN Bug 8890: C4/HoldsQueue requires DB Bug 8890: don't try to load DB-dependent modules Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN Bug 8890 - move two more db dependent tests |
||
|
Description
Chris Cormack
2012-10-09 01:40:38 UTC
Created attachment 12739 [details] [review] Bug 8890 - C4::Holdsqueue is db dependent Created attachment 12843 [details] [review] Bug 8890: C4/HoldsQueue requires DB This counter-patch moves all database handling code into subroutines in C4::HoldsQueue. This fixes the test, and is required for persistent environments like Plack. Created attachment 12844 [details] [review] Bug 8890: don't try to load DB-dependent modules Both C4::Members::Statistics and Koha::Borrower::Files use the database in their BEGIN {} blocks, which breaks the package build process. This patch causes them to be skipped in the 00-load test. Created attachment 12846 [details] [review] Bug 8890: don't try to load DB-dependent modules C4::Members::Statistics uses the database in its BEGIN {} block, which breaks the package build process. This patch causes it to be skipped in the 00-load test. Created attachment 12847 [details] [review] Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN This patch removes the usage of the database in Koha::Borrower::Files' BEGIN block. It also removes the export-related declarations, since they were unused, and unnecessary in a module called in an object-oriented fashion. Created attachment 12872 [details] [review] Bug 8890: C4/HoldsQueue requires DB This counter-patch moves all database handling code into subroutines in C4::HoldsQueue. This fixes the test, and is required for persistent environments like Plack. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 12873 [details] [review] Bug 8890: don't try to load DB-dependent modules C4::Members::Statistics uses the database in its BEGIN {} block, which breaks the package build process. This patch causes it to be skipped in the 00-load test. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 12874 [details] [review] Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN This patch removes the usage of the database in Koha::Borrower::Files' BEGIN block. It also removes the export-related declarations, since they were unused, and unnecessary in a module called in an object-oriented fashion. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 13014 [details] [review] Bug 8890 - move two more db dependent tests * t/AuthoritiesMarc.t * t/SuggestionEngine_ExplodedTerms.t The patch for bug 8846 corrects the problem with t/SuggestionEngine_ExplodedTerms.t. These patchs fix the t/00-load.t test Marked as Passed QA. Patch pushed to master The 1st patch ( Bug 8890: C4/HoldsQueue requires DB (2.19 KB, patch) ) could be pushed to 3.8 to improve Plack compatibility, I think others won't apply because related to 3.10 patches I'll change my patch to give bug 8846 priority over it, as it fixes it properly (my goal is mostly to get things building.) Oh, I see all patches were pushed to master. Disregard what I said there then. Released in 3.10.0 |