| Summary: | Plack variable scoping in basket.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Paul Poulain <paul.poulain> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Paul Poulain <paul.poulain> | 
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> | 
| Severity: | major | ||
| Priority: | P1 - high | CC: | chris, jcamins, jonathan.druart | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | |||
| Bug Blocks: | 7172 | ||
| Attachments: | 
              Bug 8892 fix Plack scoping in acquisition
               Bug 8892 fix Plack scoping in acquisition  | 
      ||
| 
 
        
          Description
        
        
          Paul Poulain
        
        
        
        
          2012-10-09 15:23:21 UTC
        
       
    Created attachment 13188 [details] [review] Bug 8892 fix Plack scoping in acquisition basket.pl has a local sub get_order_infos that require our-ing the $basketno variable Note that I had no problem with this variable. It may be some dead code, but I couldn't be sure it is, so I just switched basketno to "our" neworderempty.pl has 2 local sub that require our-ing some variables: subs MARCfindbreeding and Load_Duplicate I never had any problem with this variable scoping problems, so maybe it's some unused variable, but for safety (and having a quiet log), it's better to fix by our-ing some variables Created attachment 13374 [details] [review] Bug 8892 fix Plack scoping in acquisition basket.pl has a local sub get_order_infos that require our-ing the basketno variable. Note that I had no problem with this variable. It may be some dead code, but I couldn't be sure it is, so I just switched basketno to "our" neworderempty.pl has 2 local sub that require our-ing some variables: subs MARCfindbreeding and Load_Duplicate Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: This patch removes warnings in 2 pages (using Plack). Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0  |