Bug 8892

Summary: Plack variable scoping in basket.pl
Product: Koha Reporter: Paul Poulain <paul.poulain>
Component: Architecture, internals, and plumbingAssignee: Paul Poulain <paul.poulain>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart+koha>
Severity: major    
Priority: P1 - high CC: chris, jcamins, jonathan.druart+koha
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 7172    
Attachments: Bug 8892 fix Plack scoping in acquisition
Bug 8892 fix Plack scoping in acquisition

Description Paul Poulain 2012-10-09 15:23:21 UTC
Variable "$basketno" is not available at /home/paul/koha.dev/koha-community/acqui/basket.pl line 359.
Comment 1 Paul Poulain 2012-11-02 09:22:45 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2012-11-02 09:29:45 UTC
I never had any problem with this variable scoping problems, so maybe it's some unused variable, but for safety (and having a quiet log), it's better to fix by our-ing some variables
Comment 3 Jared Camins-Esakov 2012-11-10 13:55:40 UTC
Created attachment 13374 [details] [review]
Bug 8892 fix Plack scoping in acquisition

basket.pl has a local sub get_order_infos that require our-ing the
basketno variable.
Note that I had no problem with this variable. It may be some dead code,
but I couldn't be sure it is, so I just switched basketno to "our"

neworderempty.pl has 2 local sub that require our-ing some variables:
subs MARCfindbreeding and Load_Duplicate

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 4 Jonathan Druart 2012-11-12 16:26:47 UTC
QA comment:

This patch removes warnings in 2 pages (using Plack).

Marked as Passed QA.
Comment 5 Jared Camins-Esakov 2012-11-12 23:52:26 UTC
This patch has been pushed to master.
Comment 6 Paul Poulain 2012-11-16 17:30:23 UTC
Patch pushed to branch 3.10.x
Comment 7 Chris Cormack 2013-04-22 10:15:11 UTC
Released in 3.10.0