Summary: | show more information on printout | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, melia, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/catalogue/detailprint.pl?biblionumber=4091 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8893 - show more information on printout
[SIGNED-OFF] Bug 8893 - show more information on printout Bug 8893 - show more information on printout Bug 8893 [Follow-up] show more information on printout [Signed off] Bug 8893 [Follow-up] show more information on printout Bug 8893 [Follow-up] show more information on printout |
Description
Nicole C. Engard
2012-10-09 17:00:34 UTC
Created attachment 13055 [details] [review] Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Created attachment 13057 [details] [review] [SIGNED-OFF] Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> QA Comment: Owen, I like your patch because it removes a script :) But is it not too radical ? I would like to have at least another point of view on this new behaviour. For example, with your patch, a notice is printed on 2 pages instead of 1. For the print button: your patch gives the same result as the browser print controls. Maybe it is the opportunity to delete this button ? For discussion. QA comment: * remove a lot of code, ++ * passes koha-qa.pl * I don't see any possible side-effect * feature works passed QA Created attachment 13783 [details] [review] Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch looks very good, except for one thing: there is still a reference to detailprint.pl in cat-toolbar.inc. Could you please provide a follow-up removing it? Created attachment 13802 [details] [review] Bug 8893 [Follow-up] show more information on printout This follow-up removes the old link to detailprint.pl and replaces it with an empty container as a hook for the YUI button function. The appearance and functionality should not be any different. Created attachment 13803 [details] [review] [Signed off] Bug 8893 [Follow-up] show more information on printout This follow-up removes the old link to detailprint.pl and replaces it with an empty container as a hook for the YUI button function. The appearance and functionality should not be any different. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Just adding my signoff to the follow up. I tried printing a record from the staff client and verified that you can see the shelving location on the printout. Looks good. Created attachment 13839 [details] [review] Bug 8893 [Follow-up] show more information on printout This follow-up removes the old link to detailprint.pl and replaces it with an empty container as a hook for the YUI button function. The appearance and functionality should not be any different. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch removes a ref to detailprint.pl. With JS a "Print" button is displayed (else it is not). This patch has been pushed to master. |