Summary: | Improve OAI management interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, m.de.rooy, mirko |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9201 | ||
Attachments: |
Bug 8906 - Improve OAI management interface
Bug 8906 - Improve OAI management interface Bug 8906: Followup FIX hardcoded localhost url Bug 8906: Followup FIX hardcoded localhost url Bug 8906: Followup replace 'Clear' with 'Delete' [SIGNED-OFF] Bug 8906: Followup replace 'Clear' with 'Delete' Bug 8906 - Improve OAI management interface Bug 8906: Followup FIX hardcoded localhost url Bug 8906: Followup replace 'Clear' with 'Delete' |
Description
Owen Leonard
2012-10-11 19:17:27 UTC
Created attachment 12775 [details] [review] Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. Created attachment 12898 [details] [review] Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 13561 [details] [review] Bug 8906: Followup FIX hardcoded localhost url Jonathan, I can't find any reference to localhost in that file. Maybe this was fixed with some other patch already? Ah, my bad. I had applied both patches already :) Created attachment 14107 [details] [review] Bug 8906: Followup FIX hardcoded localhost url Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Hey Owen, now that I had a look at it again, wouldn't it be more straightforward to replace the 'clear' button with a 'replace' button that clears, saves and thus deletes the row? (In reply to comment #7) > now that I had a look at it again, wouldn't it be more straightforward to > replace the 'clear' button with a 'replace' button that clears, saves and > thus deletes the row? I don't understand. Oh, sorry, I meant to write 'delete', not 'replace'. The 'clear' button now clears the fields and I was wondering if it would make sense to clear and save, which would result in a deletion. I hope i worded it better this time. Owen, What do you think about Mirko's proposition? I think he is right, but I let you give you opinion. I will submit a patch with this modification, please signoff or mark it as obsolete if you want. Created attachment 14262 [details] [review] Bug 8906: Followup replace 'Clear' with 'Delete' Created attachment 14299 [details] [review] [SIGNED-OFF] Bug 8906: Followup replace 'Clear' with 'Delete' Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA: Looking at this one now. Created attachment 15338 [details] [review] Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 15339 [details] [review] Bug 8906: Followup FIX hardcoded localhost url Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 15340 [details] [review] Bug 8906: Followup replace 'Clear' with 'Delete' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Looks good to me. Improving interface. Just wondering ("somewhat" outside the scope): Deleting a set is without confirmation? I agree that clearing one line in a set does not need a confirm, but before deleting possibly lots of lines..? Passed QA This patch has been pushed to master. |