Summary: | Referential integrity constraints and InnoDB vs MyISAM storage engine | ||
---|---|---|---|
Product: | Koha | Reporter: | Frédéric Demians <f.demians> |
Component: | Architecture, internals, and plumbing | Assignee: | Frédéric Demians <f.demians> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jcamins, jonathan.druart, kyle, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 1963 | ||
Attachments: |
Script fixing missing constraints
Script fixing missing constraints Bug 8915 A script fixing missing MySQL contraints Bug 8915: Followup FIX QA issues Bug 8915: Followup FIX QA issues |
Description
Frédéric Demians
2012-10-13 07:45:50 UTC
Created attachment 12799 [details] [review] Script fixing missing constraints Created attachment 12804 [details] [review] Script fixing missing constraints Standalone script, does what it says it does, and needs a confirmation switch to run. Created attachment 13166 [details] [review] Bug 8915 A script fixing missing MySQL contraints Help: fix_mysql_contraints.pl -h Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 13342 [details] [review] Bug 8915: Followup FIX QA issues Before this patch: * misc/maintenance/fix_mysql_constraints.pl FAIL pod FAIL *** ERROR: unterminated B<...> in file misc/maintenance/fix_mysql_constraints.pl forbidden patterns OK valid OK critic FAIL "require" statement with library name as string at line 25, column 12. Use a bareword instead. + I add a die on the open statement Hi Chris and Frédéric, Could one of you confirm that you agree with my patch ? Created attachment 13355 [details] [review] Bug 8915: Followup FIX QA issues Before this patch: * misc/maintenance/fix_mysql_constraints.pl FAIL pod FAIL *** ERROR: unterminated B<...> in file misc/maintenance/fix_mysql_constraints.pl forbidden patterns OK valid OK critic FAIL "require" statement with library name as string at line 25, column 12. Use a bareword instead. + I add a die on the open statement Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Thanks Kyle. Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |