Bug 8935

Summary: transport cost matrix could be prettier
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Paul Poulain <paul.poulain>
Severity: minor    
Priority: P5 - low CC: chris, paul.poulain
Version: 3.10   
Hardware: All   
OS: All   
URL: cgi-bin/koha/admin/transport-cost-matrix.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8933, 8934    
Bug Blocks:    
Attachments: Bug 8935 - transport cost matrix could be prettier
[SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier

Description Nicole C. Engard 2012-10-16 19:40:45 UTC
This page might benefit from some style changes to match the styles used throughout the staff client.
Comment 1 Owen Leonard 2012-10-17 16:58:00 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-10-17 17:19:50 UTC
Created attachment 12888 [details] [review]
[SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier

Correcting the template so that it follows established
interface patterns and coding guidelines:

- Form contents in a fieldset
- Submit button in a fieldset with class "action" and
  with a "Cancel" link.
- Errors displayed in a <div class="dialog alert">
  (no custom error classes necessary).
- Valid markup.
- No JavaScript errors (to that end, the patch removes a
  call to a non-existent function, show_transport_cost_matrix)

http://bugs.koha-community.org/show_bug.cgi?id=8936
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
still works as expected and is much more visually appealing.
Comment 3 Paul Poulain 2012-10-22 15:53:00 UTC
QA comment
 * small patch
 * template & design only patch, no side effect risk
 * passes koha-qa.pl

passed QA
Comment 4 Paul Poulain 2012-10-22 15:53:21 UTC
Patch pushed to master (3.10 only, transport cost matrix being 3.10 specific)
Comment 5 Chris Cormack 2013-04-21 00:53:08 UTC
Released in 3.10.0