Summary: | transport cost matrix could be prettier | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/admin/transport-cost-matrix.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8933, 8934 | ||
Bug Blocks: | |||
Attachments: |
Bug 8935 - transport cost matrix could be prettier
[SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier |
Description
Nicole C. Engard
2012-10-16 19:40:45 UTC
Created attachment 12887 [details] [review] Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 Created attachment 12888 [details] [review] [SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> still works as expected and is much more visually appealing. QA comment * small patch * template & design only patch, no side effect risk * passes koha-qa.pl passed QA Patch pushed to master (3.10 only, transport cost matrix being 3.10 specific) Released in 3.10.0 |