Bug 8968

Summary: JavaScript String not translatable
Product: Koha Reporter: Frédéric Demians <f.demians>
Component: translate.koha-community.orgAssignee: Frédéric Demians <f.demians>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: normal    
Priority: P5 - low CC: chris, f.demians, jcamins, jonathan.druart, liz, paul.poulain
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 8968 "Add to cart" translatable on OPAC result page
[SIGNED-OFF] Bug 8968 "Add to cart" translatable on OPAC result page

Description Frédéric Demians 2012-10-25 08:05:23 UTC
This is an omnibus bug, where to attach patch fixing strings in JavaScript code which are not translatable since there are not surrounded with _( ).
Comment 1 Frédéric Demians 2012-10-25 08:09:30 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-10-25 18:31:46 UTC
Created attachment 13061 [details] [review]
[SIGNED-OFF] Bug 8968 "Add to cart" translatable on OPAC result page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2012-11-13 14:53:01 UTC
Simple and logical patch.
Marked as Passed QA.
Comment 4 Jared Camins-Esakov 2012-11-13 15:01:30 UTC
This patch has been pushed to master.
Comment 5 Chris Cormack 2012-11-13 21:59:43 UTC
Pushed to 3.8.x, will be in 3.8.7
Comment 6 Paul Poulain 2012-11-16 17:35:22 UTC
Patch pushed to branch 3.10.x
Comment 7 Liz Rea 2012-11-28 01:46:41 UTC

Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. 

Thanks!