Bug 8980

Summary: Untranslatable strings in modborrowers.pl
Product: Koha Reporter: Owen Leonard <oleonard>
Component: PatronsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Paul Poulain <paul.poulain>
Severity: major    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, paul.poulain
Version: 3.10   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 8986    
Attachments: Bug 8980 - Untranslatable strings in modborrowers.pl
Bug 8980 - Untranslatable strings in modborrowers.pl

Description Owen Leonard 2012-10-29 19:21:28 UTC
The patron batch modification script, modborrowers.pl, defines English language strings as labels for the form fields in the template. This makes the labels untranslatable.
Comment 1 Owen Leonard 2012-10-29 19:28:53 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-10-30 10:20:30 UTC
Created attachment 13109 [details] [review]
Bug 8980 - Untranslatable strings in modborrowers.pl

This patch removes the declaration of interface labels
from the script and puts it in the template where the
labels can be translated. The labels have been modified
to match those used on the patron entry form.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 3 Paul Poulain 2012-10-30 17:29:44 UTC
QA comment
 * patch needed for translating labels
 * even if it's string freeze, this patch can be pushed because it's not translatable now, so it won't change nothing for 3.10.0 = labels won't be translated !
 * passes koha-qa.pl

passed QA
Comment 4 Paul Poulain 2012-10-30 17:29:58 UTC
Patch pushed to master