Bug 8989

Summary:	Availability facet needs an id
Product:	Koha	Reporter:	Gaetan Boisson <gaetan.boisson>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Mason James <mtj>
Severity:	enhancement
Priority:	P5 - low	CC:	jcamins, mtj, paul.poulain
Version:	3.10
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 8989 - Availability facet needs an id [SIGNED-OFF] Bug 8989 - Availability facet needs an id

Description Gaetan Boisson 2012-10-30 17:25:57 UTC

Facets in search results (both in the staff interface and in the opac) have ids for css styling, except for the availability facet.

It would be useful to have one, especially since this feature seems to have been broken for a while and this would allow us to hide it. Ideally i think we could hide it in the default css in the same patch.

Comment 1 Owen Leonard 2012-10-31 16:07:36 UTC Comment hidden (obsolete)

Created attachment 13146 [details] [review]
Bug 8989 - Availability facet needs an id

This patch adds an id to the <li> which contains
the "limit to available" facet in the OPAC and
staff client.

To test, add custom CSS for the staff client and
OPAC to hide the id "availability_facet" and
confirm that the link is no longer visible.

Comment 2 Owen Leonard 2012-10-31 16:09:06 UTC

I didn't add anything to the default CSS because as far as I can tell the limit to available feature isn't working perfectly but is working.

Comment 3 Gaetan Boisson 2012-11-02 14:51:17 UTC

Created attachment 13233 [details] [review]
[SIGNED-OFF] Bug 8989 - Availability facet needs an id

This patch adds an id to the <li> which contains
the "limit to available" facet in the OPAC and
staff client.

To test, add custom CSS for the staff client and
OPAC to hide the id "availability_facet" and
confirm that the link is no longer visible.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>

Comment 4 Gaetan Boisson 2012-11-02 14:52:08 UTC

Works as advertised!

Comment 5 Mason James 2012-11-09 03:00:15 UTC

(In reply to comment #3)
> Created attachment 13233 [details] [review]
> [SIGNED-OFF] Bug 8989 - Availability facet needs an id
> Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>

tested working, passing QA...

$ koha-qa.pl -c 1 
testing 1 commit(s) (applied to 9ace63b 'Bug 9001: Remove Zebraqueue_daemon')

 a665277 Bug 8989 - Availability facet needs an id
 - koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
 - koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc

 * koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc                      OK
 * koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc                     OK

Comment 6 Jared Camins-Esakov 2012-11-09 04:30:30 UTC

This patch has been pushed to master.

Comment 7 Paul Poulain 2012-11-12 13:25:19 UTC

Patch pushed to branch 3.10.x