Summary: | Dead code in C4/Language causing useless SQL queries | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Architecture, internals, and plumbing | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jcamins, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8997: In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it to _build_languages_arrayref, that does nothing of it
Bug 8997: Unnecessary call to getAllLanguages |
Description
Paul Poulain
2012-10-31 17:21:23 UTC
Created attachment 13150 [details] [review] Bug 8997: In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it to _build_languages_arrayref, that does nothing of it removing this dead code will clean & reduce SQL overhead Test plan: * apply patch * use Koha (with some languages activated on staff & OPAC) => you won't see any differences (i've tested both Plack & CGI) Created attachment 13209 [details] [review] Bug 8997: Unnecessary call to getAllLanguages In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it to _build_languages_arrayref, that does nothing of it. Removing this dead code will clean & reduce SQL overhead Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> I tried switching between languages and enabling and disabling languages, and could not see any change with the patch applied. Good catch Paul. Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |