Summary: | Add css fix for opac news items with strong and em | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | OPAC | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, chris, m.de.rooy |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 9003 - Add css fix for opac news items with strong and em
Bug 9003 - Add css fix for opac news items with strong and em Bug 9003 - Add css fix for opac items with strong and em [SIGNED-OFF] Bug 9003 - Add css fix for opac items with strong and em Bug 9003 - Add css fix for opac items with strong and em |
Description
David Cook
2012-10-31 22:25:43 UTC
Created attachment 13161 [details] [review] Bug 9003 - Add css fix for opac news items with strong and em Simple bit of css which doesn't affect anything outside of the opac news box. Created attachment 13162 [details] [review] Bug 9003 - Add css fix for opac news items with strong and em Replaced child selector with descendant selector to match the rest the staff-global.css file... This change looks correct to me, but I don't see any reason for you to limit it to #news. Can you please resubmit so that em and strong work well together globally? Created attachment 15127 [details] [review] Bug 9003 - Add css fix for opac items with strong and em Good point, Owen. I notice in the staff client that it handles the strong and em nesting for all items and not just news, so here is my updated patch! Created attachment 15193 [details] [review] [SIGNED-OFF] Bug 9003 - Add css fix for opac items with strong and em Currently, if you have nested strong and em tags in the opac, you will only get the properties of the inner tag. This seems to be due to reset-fonts-grids.css resetting the font weight and style (for both strong and em) to normal. So if you have strong as your outer tag and em as your inner tag, you'll have italics but no bold. To test: Before applying the patch... 1) Put <em> and <strong> tags around some text in the opacnav, opac news, opacheader, or any other area of the opac where you can enter html text. 2) Look at the opac and notice that only the inner tag styles are being applied to the text Apply the patch 3) Refresh the opac (you may need to bypass or clear your browser cache for the new style to pick up) 4) Note that both the inner and outer <em> and <strong> tags are being applied to the text (i.e. your text should be bold and italicized) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small change that works. No errors. Created attachment 16833 [details] [review] Bug 9003 - Add css fix for opac items with strong and em Currently, if you have nested strong and em tags in the opac, you will only get the properties of the inner tag. This seems to be due to reset-fonts-grids.css resetting the font weight and style (for both strong and em) to normal. So if you have strong as your outer tag and em as your inner tag, you'll have italics but no bold. To test: Before applying the patch... 1) Put <em> and <strong> tags around some text in the opacnav, opac news, opacheader, or any other area of the opac where you can enter html text. 2) Look at the opac and notice that only the inner tag styles are being applied to the text Apply the patch 3) Refresh the opac (you may need to bypass or clear your browser cache for the new style to pick up) 4) Note that both the inner and outer <em> and <strong> tags are being applied to the text (i.e. your text should be bold and italicized) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small change that works. No errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Nothing to say. Very small css change. Passed QA This patch (and a follow-up for CCSR) has been pushed to master. Pushed to 3.10.x will be in 3.10.5 |