|
Description
Paul Poulain
2012-11-02 11:48:16 UTC
Created attachment 13201 [details] [review] Bug 9008: warn if user is logged-in with admin account Test plan: * log-in staff interface with admin (mysql) account => there's a large warning on the homepage * log-in with another account => nothing displayed Created attachment 13202 [details] [review] [SIGNED-OFF] Bug 9008: warn if user is logged-in with admin account Test plan: * log-in staff interface with admin (mysql) account => there's a large warning on the homepage * log-in with another account => nothing displayed Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> There is a typo:
+ <div id="adminwarning"i class="alert">
That should be:
<div id="adminwarning" class="dialog alert">
I also suggest wrapping "Warning:" in <strong>
Created attachment 13216 [details] [review] Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account - Correcting typo - Adding markup tweaks - Adjusting the wording of the warning Created attachment 13243 [details] [review] Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account - Correcting typo - Adding markup tweaks - Adjusting the wording of the warning Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Simple patch. It adds a warning message if the logged-in user is the admin account. Marked as Passed QA. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.1 |