| Summary: | Add additional sample data to German installer | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Installation and upgrade (web-based installer) | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, jcamins, kyle, liz, mirko, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9024: Adding sample patron attributes to German web installer
Bug 9023: Add missing sample data to existing files Bug 9023: Add missing sample data to existing files Bug 9024: Fix typo |
||
|
Description
Katrin Fischer
2012-11-07 14:29:59 UTC
Currently the optional sample data is misssing following files: - marc21_relatorterms - sample_quotes - patron_attributes Created attachment 13284 [details] [review] Bug 9024: Adding sample patron attributes to German web installer Adds SHOW_BCODE as sample patron attribute to the German web installer. To test: - Run the web installer in German, make sure the new sample data shows up and can be installed. Created attachment 13285 [details] [review] Bug 9023: Add missing sample data to existing files Adds missing authorised values (enhancement) Adds missing slip notice templates (bug fix) Koha will complain if you try to print a slip and there is no notice defined for them, so this is not really an improvement, but kind of a bug fix. Changing this from enhancement to normal, because the missing slip templates result in an unhappy Koha trying to print slips from circulation. Again, this is string safe, as translation here is done outside of po files. QA comment: german install only files, passed QA Created attachment 13566 [details] [review] Bug 9023: Add missing sample data to existing files Adds missing authorised values (enhancement) Adds missing slip notice templates (bug fix) Koha will complain if you try to print a slip and there is no notice defined for them, so this is not really an improvement, but kind of a bug fix. Created attachment 13567 [details] [review] Bug 9024: Fix typo I checked both patches for language and functionality. All is fine but there is one tiny typo, I attached a patch. This patch has been pushed to master. Patch pushed to branch 3.10.x Pushed to 3.8.x, will be in 3.8.8 Pushed to 3.6.x will be in 3.6.11. Hi Liz, 3.6 does have the old notices module, so slips are not configurable there. And I am not sure about the patron attribute to show barcodes but think this was introduced a little later too. Can you maybe revert those 2 patches? Sorry for the confusion! Reverted. Thanks for catching this. Liz |