Bug 9039

Summary: Tests in the basic test suite should only test code based on required dependencies/modules
Product: Koha Reporter: Chris Nighswonger <cnighswonger>
Component: Test SuiteAssignee: Chris Nighswonger <cnighswonger>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P5 - low CC: chris, jcamins, paul.poulain
Version: 3.10   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9039 - Tests in the basic test suite should only test code based on required dependencies/modules
Bug 9039 - Tests in the basic test suite should only test code based on required dependencies/modules
Bug 9039 - Tests in the basic test suite should only test code based on required dependencies/modules

Description Chris Nighswonger 2012-11-08 21:12:58 UTC
Tests for optional dependencies should be moved to an "optional" subdirectory wihtin the t directory
Comment 1 Chris Nighswonger 2012-11-08 21:15:27 UTC Comment hidden (obsolete)
Comment 2 Chris Nighswonger 2012-11-08 21:16:41 UTC
Attached patch creates the afforementioned subdirectory and moves a Memcached centric test into it. This subdir should be used for other tests which are based upon optional modules/dependencies.
Comment 3 Chris Cormack 2012-11-08 23:56:46 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2012-11-12 17:19:09 UTC
QA comment: no code change, just moving a test to a new subdirectory, that is a good idea

passed QA
Comment 5 Paul Poulain 2012-11-12 17:19:18 UTC
Created attachment 13403 [details] [review]
Bug 9039 - Tests in the basic test suite should only test code based on required dependencies/modules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 6 Jared Camins-Esakov 2012-11-13 01:06:49 UTC
This patch has been pushed to master.
Comment 7 Paul Poulain 2012-11-16 17:33:41 UTC
Patch pushed to branch 3.10.x
Comment 8 Chris Cormack 2013-04-22 10:17:40 UTC
Released in 3.10.0