Summary: | Quote editor does not work under Plack | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Tools | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, magnus, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12163 | ||
Bug Blocks: | 12173 | ||
Attachments: |
Bug 9048 - fix quote editor under plack
Bug 9048 - fix quote editor under Plack Bug 9048 - fix quote editor under Plack |
Description
Jared Camins-Esakov
2012-11-10 00:58:43 UTC
Confirmed. Additionally, Koha doesn't handle this very well. It just sits there rather than letting the user know something had an upset. Created attachment 27791 [details] [review] Bug 9048 - fix quote editor under plack The ajax responder for the quote editor was using the wrong error codes. These have been fixed. Also, a small fixup to get rid of some annoying warnings. To test: * Under plack, * Add/edit/delete a quote. * Make sure that things don't crash. Fixed the error codes. There seems to be a bug in the JS that prevents adding quotes showing up like they've been added until you refresh. That seems to be an unrelated bug that I'll have a quick look into. Everything else works however. Marking as blocked by bug 12163, which fixes the JS issue, as this is hard to test properly without that. Created attachment 27987 [details] [review] Bug 9048 - fix quote editor under Plack The ajax responder for the quote editor was using the wrong error codes. These have been fixed. Also, a small fixup to get rid of some annoying warnings. To test: * Under plack, * Add/edit/delete a quote. * Make sure that things don't crash. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 28113 [details] [review] Bug 9048 - fix quote editor under Plack The ajax responder for the quote editor was using the wrong error codes. These have been fixed. Also, a small fixup to get rid of some annoying warnings. To test: * Under plack, * Add/edit/delete a quote. * Make sure that things don't crash. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Robin! |