This is still true for managing staged imports on current master: item options are offered and displayed in the summary. Created attachment 37416 [details] [review] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" No behavior should exist on importing bibliographic records. (In reply to Magnus Enger from comment #0) > the text "Add new bibliographic records into this framework:" followed by a > dropdown containing the bibliographic frameworks. See attached screenshot. This has been done by bug 10097. Comment on attachment 37416 [details] [review] Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37416 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +306,5 @@ > [% END %] > [% END %] > </li> > + > + [% IF ( record_type == 'biblio' ) %] You missed the section around line 378: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 Changing to Failed QA, simply because of the block of item counts was displayed: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 while viewing .../cgi-bin/koha/tools/manage-marc-import.pl Everything else looked great. Just fix that tiny piece. Created attachment 37674 [details]
Sample 1 record authority MRC file.
Attaching sample authority record that I used for testing.
Created attachment 37713 [details] [review] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Comment on attachment 37713 [details] [review] Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37713 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +378,5 @@ > + [% IF ( record_type == 'biblio' ) %] > + <tr><td>Number of items added</td><td>[% num_items_added %]</td></tr> > + <tr><td>Number of items replaced</td><td>[% num_items_replaced %]</td></tr> > + <tr><td>Number of items ignored because of duplicate barcode</td><td>[% num_items_errored %]</td></tr> > + [ % END %] Tiny spacing issue. Fixing and signing off. Created attachment 38510 [details] [review] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Created attachment 38511 [details] [review] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38512 [details] [review] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38630 [details] [review] [PASSED QA] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38631 [details] [review] [PASSED QA] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Please rebase for inclusion ASAP. Created attachment 39188 [details] [review] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 39189 [details] [review] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed conflict, retested, reset back to Passed QA. (*grumbles about commas and white space making things conflict so easily*) Patches pushed to master. Thanks Jonathan and Mark! |
Created attachment 13417 [details] Managing a staged authority file After uploading a MARC file on "Home › Tools › Stage MARC records for import" it is possible to choose "Authority" as the "Record type". Doing this hides the "Check for embedded item record data?" question correctly. However, after clicking on "Stage for import", the list of feedback includes "0 item records found and staged". After clicking on the "Manage staged records" link on that same screen, the new screen that appears includes an option for "Item processing" as well as the text "Add new bibliographic records into this framework:" followed by a dropdown containing the bibliographic frameworks. See attached screenshot. I tried staging/importing an example file from another bug, and it did get imported OK, so this problem might be mostly cosmetic.