Summary: | Searching for authority from tag editor for field 650 gives error | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | MARC Authority data support | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jcamins, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9070: authority searches in auth_finder error out
Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out Bug 9070: authority searches in auth_finder error out Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out |
Description
Magnus Enger
2012-11-13 15:45:37 UTC
Created attachment 13438 [details] [review] Bug 9070: authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Created attachment 13439 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. Created attachment 13440 [details] [review] Bug 9070: authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Created attachment 13441 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1. QA comment : * passes koha-qa.pl * works as advertised * no string changes passed QA Created attachment 13553 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch has been pushed to master. This patch is in 3.10.x and 3.8.x (was in 3.10.0 release will be 3.8.8) |