Summary: | Installer will not run with DEBUG set | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Nighswonger <cnighswonger> |
Component: | Architecture, internals, and plumbing | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jcamins, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9085 - Installer will not run with DEBUG set
Bug 9085 - Installer will not run with DEBUG set Bug 9085 - Installer will not run with DEBUG set |
Description
Chris Nighswonger
2012-11-14 20:35:28 UTC
Created attachment 13455 [details] [review] Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. Created attachment 13459 [details] [review] Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The installer can now be run both with and without DEBUG set. QA comment: * I checked that this patch changed nothing in usual cases * add a safety check, usefull only if DEBUG is set. Maybe the test could have been done only when DEBUG is ON, but with Plack, dbh will be much more persistant than CGI, so the cost of the new eval {} is OK * passes koha-qa.plr passed QA Created attachment 13547 [details] [review] Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The installer can now be run both with and without DEBUG set. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch has been pushed to master. Patch pushed to branch 3.10.x Pushed to 3.8.x will be in 3.8.7 |