Summary: | country in CSV in overdue_notices.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Command-line Utilities | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 9104: country in CSV headers in overdue_notices.pl Proposed patch (revisited) [SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl [SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl |
Description
Fridolin Somers
2012-11-19 13:20:27 UTC
Created attachment 13512 [details] [review] Proposed patch Proposed patch removes country from headers and for SQL query on borrowers table. This patch and Bug 9103 patch edits some same lines. So first integrated will cause other rebase of the other. Created attachment 13581 [details] [review] Bug 9104: country in CSV headers in overdue_notices.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I am not sure removing country is the right way to go. If you are using the overdues CSV file to create printed overdue notices, it's information you need for a complete address. Created attachment 13836 [details] [review] Proposed patch (revisited) Revisited patch to add country of borrower into CSV instead of removing the header. Created attachment 13921 [details] [review] [SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 14160 [details] [review] [SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Output of of the overdues script with -csv now contains country from the first address in the patron account. I checked output for 2 patrons, one with and one without country in the patron's address. All tests pass. Perlcritic fails before and after: "require" statement with library name as string at line 29, column 12. Use a bareword instead. (Severity: 5) This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 |