| Summary: | 942e tied to undefined CN_EDITION in default MARC21 framework | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | MARC Bibliographic data support | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9124: Remove non-existing field mapping and auth value for 942$e
Bug 9124: Remove non-existing field mapping and auth value for 942$e [PASSED QA] Bug 9124: Remove non-existing field mapping and auth value for 942$e |
||
This is still the case. It gets even worse... biblioitems.cn_edition doesn't exist? Created attachment 34024 [details] [review] Bug 9124: Remove non-existing field mapping and auth value for 942$e 942$e is mapped to biblioitems.cn_edition, which doesn't exist and to an authorized value CN_EDITION, which doesn't exist either. Patch removes the wrong mapping and non-existing auth value from the frameworks. To test: - git diff --color-words HEAD^ is helpful - Check all mappings are changes and SQL is still valid Created attachment 34737 [details] [review] Bug 9124: Remove non-existing field mapping and auth value for 942$e 942$e is mapped to biblioitems.cn_edition, which doesn't exist and to an authorized value CN_EDITION, which doesn't exist either. Patch removes the wrong mapping and non-existing auth value from the frameworks. To test: - git diff --color-words HEAD^ is helpful - Check all mappings are changed and SQL is still valid Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 34863 [details] [review] [PASSED QA] Bug 9124: Remove non-existing field mapping and auth value for 942$e 942$e is mapped to biblioitems.cn_edition, which doesn't exist and to an authorized value CN_EDITION, which doesn't exist either. Patch removes the wrong mapping and non-existing auth value from the frameworks. To test: - git diff --color-words HEAD^ is helpful - Check all mappings are changed and SQL is still valid Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Katrina! |
Looks like 942e is tied to an authorized value called CN_EDITION in the default MARC21 framework (perhaps in other frameworks too, I didn't check): ('942', 'e', 'Edition', 'Edition', 0, 0, 'biblioitems.cn_edition', 9, 'CN_EDITION', '', '', NULL, 0, '', '', '', NULL), http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql;hb=HEAD#l79 CN_EDITION is not defined in either of these: installer/data/mysql/en/mandatory/auth_values.sql installer/data/mysql/en/optional/auth_val.sql This results in an empty dropdown for the 942e field on the cataloguing screen.