Summary: | Failing test case in 3.10.0 release. | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Test Suite | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | blocker | ||
Priority: | P1 - high | CC: | chris, jcamins, tomascohen |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9142 - Remove the use of subtests
Bug 9142 - Remove the use of subtests [SIGNED-OFF] Bug 9142 - Remove the use of subtests |
Description
Robin Sheat
2012-11-26 04:51:31 UTC
This is coming from commit 5d92ab39a681e370635324f1fdb9e69b187e7842, btw. This is because the test case in bug 8800 was written with a higher version of Test::More than ships in Debian stable, and so that test doesn't work. Created attachment 13679 [details] [review] Bug 9142 - Remove the use of subtests Debian stable's version of Test::More is older than the one I used on my 12.04 dev box, and doesn't support subtests, which I used to avoid side effects between different test scenarios. This patch removes that subtest definition. Thanks very much Tomás, this means we can put the test back in for packaging :) Created attachment 13692 [details] [review] Bug 9142 - Remove the use of subtests Debian stable's version of Test::More is older than the one I used on my 12.04 dev box, and doesn't support subtests, which I used to avoid side effects between different test scenarios. This patch removes that subtest definition. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Thanks. I've also built master packages with this, uploading them now. Created attachment 13717 [details] [review] [SIGNED-OFF] Bug 9142 - Remove the use of subtests Debian stable's version of Test::More is older than the one I used on my 12.04 dev box, and doesn't support subtests, which I used to avoid side effects between different test scenarios. This patch removes that subtest definition. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.1 Pushed to 3.8.x, will be in 3.8.8 |