|
Description
Owen Leonard
2012-11-29 14:47:05 UTC
This bug blocks Bug 7261 because it is through the configuration file that the CalendarFirstDayOfWeek preference is applied. Created attachment 13770 [details] [review] Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Created attachment 13844 [details] [review] Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 14010 [details] [review] Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment: 1- opac-user.tt also has a date picker (to suspend a placed hold). Shouldn't we update this page too ? 2- passes koha-qa.pl If answer to Q1 is "no", owen, you can pass QA, it work well & does the job. If the answer to Q1 is "yes", owen, a follow-up is welcomed ;-) Created attachment 14057 [details] [review] Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Created attachment 14077 [details] [review] Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> the datepicker plugin works for opac-reserve and opac-user Created attachment 14168 [details] [review] Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> the datepicker plugin works for opac-reserve and opac-user Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch has been pushed to master. Could this patch been pushed in 3.10? Thanks. Pushed to 3.10.x will be in 3.10.5 |