Bug 9167

Summary: The sort field copyrightdate is not standardized
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ListsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8032    
Bug Blocks:    
Attachments: Bug 9167: Standardize the sort field copyrightdate for lists
[SIGNED_OFF] Patch 9167

Description Jonathan Druart 2012-11-29 15:19:31 UTC
At the OPAC, the sort field is "year" and at the intranet is "copyrightdate".

To reproduce:
Create a list at the OPAC and select the sort field 'year'. Go to the list management page at the intranet: the sort field "copyrightdate" is not selected by default.
Comment 1 Jonathan Druart 2012-11-29 15:38:05 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-11-29 15:39:09 UTC
To apply AFTER Bug 8032
Comment 3 Marcel de Rooy 2012-12-06 12:26:35 UTC
Created attachment 13902 [details] [review]
[SIGNED_OFF] Patch 9167
Comment 4 Marcel de Rooy 2012-12-06 12:29:07 UTC
QA Comment:
Works as advertised. Improves code.

Small inconsistency in text: When editing a list in opac, the option is called Year. When editing in staff, it is called Copyrightdate. But on the shelves display in staff it is called Year again. Maybe send a followup? 

Passed QA
Comment 5 Jared Camins-Esakov 2012-12-06 13:33:47 UTC
This patch has been pushed to master.
Comment 6 Jonathan Druart 2012-12-07 10:58:58 UTC
(In reply to comment #4)
> Small inconsistency in text: When editing a list in opac, the option is
> called Year. When editing in staff, it is called Copyrightdate. But on the
> shelves display in staff it is called Year again. Maybe send a followup? 

Hi Marcel,
What is the correct label? "Year" or "Copyright date"?
Comment 7 Marcel de Rooy 2012-12-08 08:53:06 UTC
(In reply to comment #6)
> (In reply to comment #4)
> Hi Marcel,
> What is the correct label? "Year" or "Copyright date"?

Jonathan: I think that Year (or even Publication year) is a better match. Because we sort on the year in biblio.copyrightdate which is derived from 260c (at least in MARC21). See also the code in Biblio.pm for extracting a year from 260c into the copyrightdate field. At least, it is not a date. So, this field name in biblio is not that accurate :)