|
Description
Fridolin Somers
2012-11-29 15:38:17 UTC
Created attachment 13773 [details] [review] Proposed patch Hidden inputs of form where wrong. booksellerid and invoicedatereceived are not necessary, parcel.pl will find them using invoiceid. Created attachment 13774 [details] [review] Proposed patch (follow-up 1) Small follow-up: in parcel.pl booksellerid is set to template twice. Created attachment 13793 [details] [review] [Signed off] Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Created attachment 13794 [details] [review] [Signed off] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> I tested this on master by using the filter on the left side of the receipt summary to search by author and got the software error that Fridolyn described. After applying the patches, I am able to search by author, title, basket and order line without getting any software error, so I am signing off! Created attachment 13809 [details] [review] [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly Created attachment 13810 [details] [review] Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Created attachment 13811 [details] [review] [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly Created attachment 13812 [details] [review] [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 13813 [details] [review] [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly This patch has been pushed to master. Pushed to 3.10.x, will be in 3.10.1 |