Summary: | Wrap relator code in <span> to allow for CSS customization | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, kyle, magnus, mathsabypro, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10173 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9169 - Wrap relator code in <span> to allow for CSS customization
[SIGNED-OFF] Bug 9169 - Wrap relator code in <span> to allow for CSS customization Bug 9169 - Wrap relator code in <span> to allow for CSS customization |
Description
Owen Leonard
2012-11-29 16:00:30 UTC
Sorry, bibliographic records, not authorities. Created attachment 13778 [details] [review] Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } Created attachment 13943 [details] [review] [SIGNED-OFF] Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment * tiny patch, touches XSLT only, no side effect risk * passes koha-qa.pl passed QA (QUESTION TO MAGNUS : don't you need the same patch for NORMARC ?) Created attachment 14241 [details] [review] Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.2 Pushed to 3.8.x, will be in 3.8.9 (In reply to comment #4) > (QUESTION TO MAGNUS : don't you need the same patch for NORMARC ?) No, it does not look like NORMARC uses relator codes. But thanks for thinking about us! :-) I think a followup would be usefull for Unimarc. I will make a new bug for it. M. Saby |