Summary: | Wrong branch filter after suggestion creation | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 9226: Wrong branch filter after suggestion creation Bug 9226: Wrong branch filter after suggestion creation |
Description
Fridolin Somers
2012-12-06 14:11:03 UTC
Created attachment 13905 [details] [review] Proposed patch Proposed patch : Bug comes from the fact that the inputs of branch selection at creation and input of branch filtering have the same name. So $branchfilter gets a value when it souldn't. Created attachment 14273 [details] [review] [SIGNED-OFF] Bug 9226: Wrong branch filter after suggestion creation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, upon submitting a new suggestion in the staff client I was redirected to a view which was not filtered by branch. After the patch I was redirected to a view which was filtered by my logged-in branch. QA: Looking at this one now. Created attachment 15336 [details] [review] Bug 9226: Wrong branch filter after suggestion creation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, upon submitting a new suggestion in the staff client I was redirected to a view which was not filtered by branch. After the patch I was redirected to a view which was filtered by my logged-in branch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Looks good to me. The patch makes a small improvement. This is outside the scope of your report: But if I clear the filter, I am still surprised that it filters by my branch. Clear actually means here something as Default. Two links: Clear and Default would be even more nice :) Organize by-combo should also keep its value and not go back to Status when the display is e.g. Library. Passed QA This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 |