Summary: | branch code instead of name in subscription-detail.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Serials | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, colin.campbell, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 9229: branch code instead of name in subscription-detail.pl Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin [SIGNED-OFF] Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin |
Description
Fridolin Somers
2012-12-06 15:33:04 UTC
Created attachment 13909 [details] [review] Proposed patch Small patch Created attachment 14136 [details] [review] Bug 9229: branch code instead of name in subscription-detail.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 14137 [details] [review] Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin Here is also an alternative version using the KohaBranchName plugin. I think it may be a bit better to do with this way, keeping our view and controller more separated ( plus it seems simpler as well ). It's the original author's and the QA teams call though. Created attachment 14165 [details] [review] [SIGNED-OFF] Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin KohaBranchName plugin is mush better indeed. QA comment: Simple patch, works as expected. Marked as Passed QA. Created attachment 14674 [details] [review] Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin Test plan: Go in a subscription detail page. Check that the "Library" information is changed from the branchcode to the branchname Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x, will be in 3.10.3 and 3.8.10 |