Bug 9235

Summary: Hardcoded values in cronjobs/backup.sh
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Command-line UtilitiesAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: minor    
Priority: P5 - low CC: chris, jonathan.druart, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9235 - Hardcoded values in cronjobs/backup.sh
[SIGNED-OFF] Bug 9235 - Hardcoded values in cronjobs/backup.sh
Bug 9235 - Hardcoded values in cronjobs/backup.sh

Description Tomás Cohen Arazi (tcohen) 2012-12-06 19:44:53 UTC
There are several hardcoded values that should be read from config files.
Comment 1 Tomás Cohen Arazi (tcohen) 2012-12-06 19:57:27 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2012-12-07 14:06:00 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-12-21 11:34:37 UTC
QA Comments:

Now the backup script gets information from the $KOHA_CONF file.

Marked as Passed QA.
Comment 4 Jonathan Druart 2012-12-21 11:35:17 UTC
Created attachment 14221 [details] [review]
Bug 9235 - Hardcoded values in cronjobs/backup.sh

This patch makes the script read those parameters from the corresponding
$KOHA_CONF file.

Regards
To+

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2012-12-21 12:21:23 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2012-12-21 19:30:59 UTC
Pushed to 3.10.x, will be in 3.10.1