Description
Kyle M Hall (khall)
2012-12-10 13:58:26 UTC
Created attachment 13976 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Created attachment 13977 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Do we need to repeat AF in this case? I would think replacing the Greetings AF by one containing branch would make for simpler processing on the client side (In reply to comment #3) > Do we need to repeat AF in this case? I would think replacing the Greetings > AF by one containing branch would make for simpler processing on the client > side Is the AF field traditionally displayed by SIP self checkout machines? I had assumed they did, which would make having them display the branchcode on the screen odd if not confusing for patrons. That is why I made add this AF field configurable on a per SIP account basis. Yes AF is for screen display. If there are multiple AFs they should result in a multiple line display. (one AF per line). (How much we can rely on units doing that is up for discussion) (In reply to comment #5) > Yes AF is for screen display. If there are multiple AFs they should result > in a multiple line display. (one AF per line). (How much we can rely on > units doing that is up for discussion) I think it's probably best we assume they do, even if many don't. The idea behind the account-level configuration for this, is so we can send this extra AF to Overdrive ( or any other SIP using service ) and not to SCO units ( in case one library is using both ). Patch tested with a sandbox, by Kyle M Hall <kyle@bywatersolutions.com> Created attachment 18210 [details] [review] Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch tested with a sandbox, by George Williams <georgew@latahlibrary.org> Created attachment 18211 [details] [review] Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=9252 Signed-off-by: George Williams <georgew@latahlibrary.org> My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. Created attachment 18212 [details] [review] [Signed off] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> This patch was tested by George and Christopher. They have verified it works, so I am signing it off on their behalf. (We had some weirdness trying to use the sandbox.) Thanks, Melia Created attachment 19083 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Created attachment 19084 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Comment on attachment 19084 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field Review of attachment 19084 [details] [review]: ----------------------------------------------------------------- ::: C4/SIP/Sip/MsgType.pm @@ +453,5 @@ > } > > + $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg ); > + $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode} ) > + if ( $server->{account}->{send_patron_home_library_in_af} ); I see at line 492 $resp = build_patron_status($patron, $lang, $fields, $server ); but line 742 has $resp = build_patron_status($patron, $patron->language, $fields); In the handle_block_patron subroutine. This means that $server will be undefined and throw a warn. Created attachment 19469 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field - QA Followup Created attachment 20264 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 20265 [details] [review] Bug 9252 - Add option to send patron's home branch in AF field - QA Followup Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Pushed to master. Thanks, Kyle! |