Summary: | Trim barcodes in offline circulation | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Circulation | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 9263: Trim barcodes in offline circulation Bug 9263 - Followup - Improve speed of substitution. Proposed patch (revisited) Bug 9263: Trim barcodes in offline circulation |
Description
Fridolin Somers
2012-12-11 16:32:19 UTC
Created attachment 14005 [details] [review] Proposed patch Created attachment 14042 [details] [review] [SIGNED-OFF] Bug 9263: Trim barcodes in offline circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 14043 [details] [review] Bug 9263 - Followup - Improve speed of substitution. References: http://perldoc.perl.org/perlfaq4.html#How-do-I-strip-blank-space-from-the-beginning%2fend-of-a-string%3f http://stackoverflow.com/questions/2313879/why-is-s-s-s-g-so-much-slower-than-two-separate-substitutions (In reply to comment #3) > Bug 9263 - Followup - Improve speed of substitution. Thanks. I think also 'g' regexp option was missing in my patch. Created attachment 14046 [details] [review] Proposed patch (revisited) My first patch was also missing 'my' in vars declarations. So I recreated a new patch including your followup. Can you re-signoff please. Created attachment 14051 [details] [review] Bug 9263: Trim barcodes in offline circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA Comment: Trivial patch. Did not test offline circ. But this patch is just housekeeping and trims spaces from barcode and cardnumber. Looks good to me. Will not hurt anyone. Passed QA This patch has been pushed to master. Please try to remember to sign off on patches when QAing. (In reply to comment #8) > This patch has been pushed to master. > > Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel (In reply to comment #8) > This patch has been pushed to master. > > Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel (In reply to comment #10) > (In reply to comment #8) > > This patch has been pushed to master. > > > > Please try to remember to sign off on patches when QAing. > > Hi Jared, > I explicitly did not add an additional signoff line because I did not test > the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in > such exceptional (!) cases be of use? (Also note that this is a trivial > patch.) > Marcel Yes, a Passed-QA-by line would be much appreciated. |