|
Description
Liz Rea
2012-12-11 21:10:00 UTC
I believe this has been fixed under Firefox but not under Chrome, which propagates the event up through the hierarchy of forms on that page. See bug 8557. Created attachment 14016 [details] [review] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Created attachment 14017 [details] [review] Bug 9268 - Followup - Making it work properly in chrome as well To test: (go through the previous test plan on chrome instead of Firefox) I should add - I haven't quite figured out how to make it work on the barcode entry field (yet) but at least the ISBN box won't cause the problem in chrome anymore. Created attachment 14018 [details] [review] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Never mind! I found a better way to make it work so it works everywhere. Sponsored by: Hauraki District Libraries, New Zealand Created attachment 14064 [details] [review] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand Created attachment 14328 [details] [review] [SIGNED-OFF] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan in Firefox and Chromium on Ubuntu. QA comment: This patch works as expected. It would be great to factorize this code (it appears in 3 tt files). Marked as Passed QA. Created attachment 14946 [details] [review] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan in Firefox and Chromium on Ubuntu. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 |