Summary: | JavaScript should conform to coding guidelines recommended by JSHint | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9284 - JavaScript should follow rules recommended by JSHint
Bug 9284 - JavaScript should follow rules recommended by JSHint Bug 9284 - JavaScript should follow rules recommended by JSHint |
Description
Owen Leonard
2012-12-13 20:54:56 UTC
Created attachment 14145 [details] [review] Bug 9284 - JavaScript should follow rules recommended by JSHint Coding style corrections to members.js: - Mixed tab/space indentation converted to spaces. - Converted "!=" and "==" to "!==" and "===" for comparisons with ''. - Adding missing semicolons. To test, create or edit a patron and confirm that validation hasn't been broken by the changes to members.js: Invalid date, empty required fields, guarantor popup, restricted-until field display, etc. http://bugs.koha-community.org/show_bug.cgi?id=9281 Created attachment 14249 [details] [review] Bug 9284 - JavaScript should follow rules recommended by JSHint Coding style corrections to members.js: - Mixed tab/space indentation converted to spaces. - Converted "!=" and "==" to "!==" and "===" for comparisons with ''. - Adding missing semicolons. To test, create or edit a patron and confirm that validation hasn't been broken by the changes to members.js: Invalid date, empty required fields, guarantor popup, restricted-until field display, etc. http://bugs.koha-community.org/show_bug.cgi?id=9281 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA Comments: This patch only changes 7 lines substituting the js comparison operators (!= with !== and == with ===) in the members.js file. No behaviour changed. Marked as Passed QA. Created attachment 14260 [details] [review] Bug 9284 - JavaScript should follow rules recommended by JSHint Coding style corrections to members.js: - Mixed tab/space indentation converted to spaces. - Converted "!=" and "==" to "!==" and "===" for comparisons with ''. - Adding missing semicolons. To test, create or edit a patron and confirm that validation hasn't been broken by the changes to members.js: Invalid date, empty required fields, guarantor popup, restricted-until field display, etc. http://bugs.koha-community.org/show_bug.cgi?id=9281 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.9 and 3.10.2 |