Description
MJ Ray (software.coop)
2012-12-16 19:18:08 UTC
Created attachment 14161 [details] [review] Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before I attempted to fix the merge conflicts, but even after doing so I got the following errors when I ran misc/cronjobs/overdue_notices.pl Global symbol "@overdue_rules" requires explicit package name at misc/cronjobs/overdue_notices.pl line 432. Global symbol "@output_chunks" requires explicit package name at misc/cronjobs/overdue_notices.pl line 623. Global symbol "$admin_email_address" requires explicit package name at misc/cronjobs/overdue_notices.pl line 641. It also looks like some code is not treating it as an array of hashrefs, but as a hashref itself. Ping! Any chance of a rebase for this one MJ? Created attachment 15779 [details] [review] Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before rebased but I have not retested yet Created attachment 15907 [details] [review] Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 18604 [details] [review] Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Simple rebase for updatedatabase Like the idea of this patch! A grep on delay1 shows me that there is still some work to do: misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: max(overd uerules.branchcode) as rulebranch, TO_DAYS(NOW())-TO_DAYS(date_due) as daysoverd ue, delay1, delay2, delay3, misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: AND ( (TO _DAYS(NOW())-TO_DAYS(date_due) ) = delay1 misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: if ( $issue->{'da ysoverdue'} == $issue->{'delay1'} ) { t/db_dependent/lib/KohaTest/Overdues/GetBranchcodesWithOverdueRules.pm:delay1, letter1, debarred1, Probably same for delay2 etc. I'll continue MJ's work. We have this feature coming in http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement and this fits nicely with #12771. I see by the diff that there are still a lot of hardcoded 1s,2s and 3s, as well as 1..3. The plan is to remove those constraints. Note to keep this alive: The first step was to change the dependency with the mtt table. Done in #13624 We have also have an overhaul of the UI and overduenotices.pl in #12772 (submitted soon after internal tests). Are there some plans to continue here? We'd love to, and we'll certain support (with testing) anyone working on it or similar patch, but it won't be us (inLibro) doing the coding at this point I'm sorry to say. Thx for the reply Philippe. Resetting assignee. |